Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single binding closure #5350

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Mar 22, 2020

Fix the match_single_binding lint when triggered inside a closure.

Fixes: #5347

changelog: Improve suggestion for [match_single_binding]

@ThibsG ThibsG force-pushed the FixSingleBindingClosure branch from da65177 to badfbbb Compare March 22, 2020 09:31
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Waiting for the rustup

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Mar 23, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2020

📌 Commit badfbbb has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 23, 2020

⌛ Testing commit badfbbb with merge c2a1f54...

bors added a commit that referenced this pull request Mar 23, 2020
Fix single binding closure

Fix the `match_single_binding` lint when triggered inside a closure.

Fixes: #5347

Changelog: none
@bors
Copy link
Contributor

bors commented Mar 23, 2020

💔 Test failed - checks-action_test

@ThibsG
Copy link
Contributor Author

ThibsG commented Mar 23, 2020

It seems like it prefers changelog: ... over Changelog :)
Can you retry @flip1995 ?

@flip1995

This comment has been minimized.

@bors

This comment has been minimized.

bors added a commit that referenced this pull request Mar 23, 2020
Fix single binding closure

Fix the `match_single_binding` lint when triggered inside a closure.

Fixes: #5347

changelog: none
@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 23, 2020

⌛ Testing commit badfbbb with merge 1ff81c1...

@bors
Copy link
Contributor

bors commented Mar 23, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 1ff81c1 to master...

@bors bors merged commit 1ff81c1 into rust-lang:master Mar 23, 2020
@ThibsG ThibsG deleted the FixSingleBindingClosure branch March 23, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match_single_binding: suggests broken code (missing curly braces)
3 participants