add size parameter for vec_box lint
#5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-cow
force-pushed
the
vec_box_threshold
branch
from
9b9a220 to
6c6d865
Compare
flip1995
approved these changes
Jan 23, 2020
basil-cow
force-pushed
the
vec_box_threshold
branch
3 times, most recently
from
9f858e1 to
90697bf
Compare
flip1995
reviewed
Jan 25, 2020
clippy_lints/src/utils/conf.rs
Outdated
| @@ -152,6 +152,8 @@ define_Conf! { | |||
| (too_many_lines_threshold, "too_many_lines_threshold", 100 => u64), | |||
| /// Lint: LARGE_STACK_ARRAYS. The maximum allowed size for arrays on the stack | |||
| (array_size_threshold, "array_size_threshold", 512_000 => u64), | |||
| /// Lint: VEC_BOX. The minimum required size for boxed type in Vec | |||
There was a problem hiding this comment.
Suggested change
| /// Lint: VEC_BOX. The minimum required size for boxed type in Vec | |
| /// Lint: VEC_BOX. The size of the boxed type in bytes, where boxing in a `Vec` is allowed |
Is 4kB based on something?
There was a problem hiding this comment.
Page size; but as I said in the pr, you are welcome to put any number you like
basil-cow
force-pushed
the
vec_box_threshold
branch
from
90697bf to
2b7bc26
Compare
|
@bors r+ Thanks! |
|
📌 Commit 2b7bc26 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 25, 2020
add size parameter for `vec_box` lint changelog: add size threshold for the `vec_box` lint, currently 4096 bytes (one page) (subject to change). Closes #3547. diff is a little bit confusing due to some refactoring (moving free functions to lint struct functions), relevant portion is [this](https://github.com/rust-lang/rust-clippy/compare/master...Areredify:vec_box_threshold?expand=1#diff-1096120ca9143af89dcc9175ea92b54aR294-R298). In hindsight should've been different commits, but oh well.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: add size threshold for the
vec_boxlint, currently 4096 bytes (one page) (subject to change). Closes #3547.diff is a little bit confusing due to some refactoring (moving free functions to lint struct functions), relevant portion is this. In hindsight should've been different commits, but oh well.