Add a text to unreachable!()
#4986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
suggested changes
Jan 3, 2020
| | | ||
| LL | let trivial_eq = Regex::new("^foobar$"); | ||
| | ^^^^^^^^^^ | ||
| note: candidate #1: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-a27846278b6a956a.rlib |
There was a problem hiding this comment.
Hm, it depends on your environment. Shouldn't be changed.
Maybe: cargo clean; cargo test resolves this failure.
There was a problem hiding this comment.
cargo update sometimes fixes this for me as well
There was a problem hiding this comment.
I usually do rm target/debug/deps/libregex*.
There was a problem hiding this comment.
Thanks for the review. I will fix this.
Comment on lines
+1
to
+4
| error[E0465]: multiple rlib candidates for `regex` found | ||
| | | ||
| = note: candidate #1: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-a27846278b6a956a.rlib | ||
| = note: candidate #2: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-18da0247c966b574.rlib |
Comment on lines
+1
to
+4
| error[E0465]: multiple rlib candidates for `regex` found | ||
| | | ||
| = note: candidate #1: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-a27846278b6a956a.rlib | ||
| = note: candidate #2: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-18da0247c966b574.rlib |
Comment on lines
+1
to
+4
| error[E0465]: multiple rlib candidates for `regex` found | ||
| | | ||
| = note: candidate #1: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-a27846278b6a956a.rlib | ||
| = note: candidate #2: /Users/YusukeAbe/code/rust/rust-clippy/target/debug/deps/libregex-18da0247c966b574.rlib |
JohnTitor
added
the
S-waiting-on-author
flip1995
requested changes
Jan 3, 2020
| span_lint(cx, UNREACHABLE, span, | ||
| "`unreachable` should not be present in production code"); | ||
| span_help_and_lint(cx, UNREACHABLE, span, | ||
| "`unreachable` should not be present in production code", "ident is neither enable nor disable"); |
There was a problem hiding this comment.
That was not, what the issue was talking about. Anyway, the requested lint already exists, so I don't think there is anything that needs to be done here.
There was a problem hiding this comment.
Thank you for the review and sorry for the misunderstanding. I will fix this.
flip1995
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4959.