Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE on unsound_collection_transmute #4975

Merged
merged 7 commits into from
Jan 3, 2020
Merged

Conversation

JohnTitor
Copy link
Member

Fixes #4968

Check if Tys are normalizable. It might show hidden false negative, I'm not sure.
Also, the regression tests are placed on two dirs, so move them to /crashes. I think it will be easier to find the right place.

changelog: Fix ICE on unsound_collection_transmute

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 1, 2020
@flip1995
Copy link
Member

flip1995 commented Jan 2, 2020

Thanks for moving the tests, I also wanted to do this recently.

Maybe we should put the is_normalizable in a utils function, in case we'll need it sometimes in the future.

@JohnTitor
Copy link
Member Author

Maybe we should put the is_normalizable in a utils function, in case we'll need it sometimes in the future.

It's reasonable, moved into utils.

@phansch
Copy link
Member

phansch commented Jan 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit bf67fcf has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 2, 2020

⌛ Testing commit bf67fcf with merge cfa0abb...

bors added a commit that referenced this pull request Jan 2, 2020
Fix ICE on `unsound_collection_transmute`

Fixes #4968

Check if `Ty`s are normalizable. It might show hidden false negative, I'm not sure.
Also, the regression tests are placed on two dirs, so move them to `/crashes`. I think it will be easier to find the right place.

changelog: Fix ICE on `unsound_collection_transmute`
@bors
Copy link
Contributor

bors commented Jan 2, 2020

💔 Test failed - status-appveyor

@phansch
Copy link
Member

phansch commented Jan 2, 2020

Huh, never saw this before. rustfmt fails:

error: couldn't read \\?\C:\projects\rust-clippy\tests\ui\crashes\..\auxiliary\use_self_macro.rs: The filename, directory name, or volume label syntax is incorrect. (os error 123)
 --> \\?\C:\projects\rust-clippy\tests\ui\crashes\ice-4671.rs:5:5
  |
5 | mod use_self_macro;
  |     ^^^^^^^^^^^^^^
rustfmt failed on C:\projects\rust-clippy\tests\ui\crashes\ice-4671.rs

Maybe move the auxiliary file into crashes, too?

@JohnTitor
Copy link
Member Author

Oh, it seems so, moved it.

@phansch
Copy link
Member

phansch commented Jan 3, 2020

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Jan 3, 2020

📌 Commit c6aeda7 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 3, 2020

⌛ Testing commit c6aeda7 with merge 2e8c3c3...

bors added a commit that referenced this pull request Jan 3, 2020
Fix ICE on `unsound_collection_transmute`

Fixes #4968

Check if `Ty`s are normalizable. It might show hidden false negative, I'm not sure.
Also, the regression tests are placed on two dirs, so move them to `/crashes`. I think it will be easier to find the right place.

changelog: Fix ICE on `unsound_collection_transmute`
@bors
Copy link
Contributor

bors commented Jan 3, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 2e8c3c3 to master...

@bors bors merged commit c6aeda7 into rust-lang:master Jan 3, 2020
@JohnTitor JohnTitor deleted the fix-4968 branch January 3, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy ICE: normalize_erasing_regions: could not fully normalize <Trait>::Assoc
4 participants