Rustup to rust-lang/rust#67707 #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
commented
Dec 31, 2019
tesuji
approved these changes
Dec 31, 2019
JohnTitor
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 9086b17 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
|
💔 Test failed - checks-travis |
|
It seems a tiny change from the latest rustc, fixed. |
|
thanks again! @bors r+ |
|
📌 Commit bf08998 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
|
💔 Test failed - checks-travis |
|
Hm, it's spurious? |
|
Not really sure: @bors retry |
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
|
💔 Test failed - checks-travis |
|
Ah, RLS will probably also need a similar Rustup. It's fine to ignore that integration test for now. |
|
Got it, let's ignore then. |
|
@bors r+ |
|
📌 Commit 18b1542 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rustup to rust-lang/rust#67707 `syntax_pos` -> `rustc_span` changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax_pos->rustc_spanchangelog: none