Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wildcard enum match lint for non_exhaustive enums #4934

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Update wildcard enum match lint for non_exhaustive enums #4934

merged 2 commits into from
Dec 23, 2019

Conversation

illicitonion
Copy link
Contributor

changelog: wildcard_enum_match_arm gives better suggestions for non_exhaustive enums

tesuji
tesuji reviewed Dec 22, 2019
View reviewed changes
clippy_lints/src/matches.rs Outdated Show resolved Hide resolved
clippy_lints/src/matches.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2019

📌 Commit 4f4444c has been approved by flip1995

@bors
Copy link
Contributor

bors commented Dec 22, 2019

⌛ Testing commit 4f4444c with merge e5b761a...

bors added a commit that referenced this pull request Dec 22, 2019
@bors
Auto merge of #4934 - illicitonion:exhaustive_match, r=flip1995
e5b761a 
Update wildcard enum match lint for non_exhaustive enums

changelog: wildcard_enum_match_arm gives better suggestions for non_exhaustive enums
@bors
Copy link
Contributor

bors commented Dec 22, 2019

💔 Test failed - status-appveyor

@flip1995
Copy link
Member

It seems that another rustup is necessary...

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Dec 22, 2019
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 23, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: new lint: mutable_key_type #4885

@bors
Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit 4f4444c has been approved by flip1995

bors added a commit that referenced this pull request Dec 23, 2019
@bors
Auto merge of #4934 - illicitonion:exhaustive_match, r=flip1995
37b7970 
Update wildcard enum match lint for non_exhaustive enums

changelog: wildcard_enum_match_arm gives better suggestions for non_exhaustive enums
@bors
Copy link
Contributor

bors commented Dec 23, 2019

⌛ Testing commit 4f4444c with merge 37b7970...

@bors
Copy link
Contributor

bors commented Dec 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 37b7970 to master...

@bors bors merged commit 4f4444c into rust-lang:master Dec 23, 2019
@flip1995 flip1995 mentioned this pull request Dec 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesuji tesuji tesuji left review comments

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illicitonion @flip1995 @bors @tesuji