Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a condition of camel case detection #4722

Closed
wants to merge 1 commit into from

Conversation

chansuke
Copy link
Contributor

Fixes #4639.

I simply added a condition to camel_case util to pass IData type of word but I'm not sure this is the right approach..

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Nov 3, 2019
@phansch
Copy link
Member

phansch commented Nov 3, 2019

@chansuke Let us know if you need any help =)

@chansuke
Copy link
Contributor Author

chansuke commented Nov 8, 2019

@phansch Thanks for your help!! I probably misunderstanding the way to detect the IData type of camel case. I simply thought that I could solve the issue by appending a condition to if c.is_uppercase() but I think it's wrong. Can you give me any suggestions for an another approach?

@chansuke
Copy link
Contributor Author

@phansch Sorry again, I am trying to detect IData with below condition

if c.is_uppercase() && !s.chars().nth(i - 1).unwrap().is_uppercase() {}

but is this a good approach to solve the problem?

@bors
Copy link
Contributor

bors commented Feb 4, 2020

☔ The latest upstream changes (presumably #5061) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995
Copy link
Member

Thanks for contributing to Clippy! Sadly this PR was not updated in quite some time. If you waited on input from a reviewer, we're sorry that this fell under the radar. If you want to continue to work on this, just reopen the PR and/or ping a reviewer.

@flip1995 flip1995 closed this May 25, 2020
@flip1995 flip1995 added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 25, 2020
@HKalbasi
Copy link
Member

finished in #6770
@rustbot label -S-inactive-closed

@rustbot rustbot removed the S-inactive-closed Status: Closed due to inactivity label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete postfix detected for enum_variant_names
6 participants