Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove tests that only ICE on CI" #4626

Closed
wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 4, 2019

This reverts commit 4318854.

changelog: none

If the integration tests pass, this closes #4607

@phansch
Copy link
Member Author

phansch commented Oct 4, 2019

@bors try

@bors
Copy link
Contributor

bors commented Oct 4, 2019

⌛ Trying commit 8a780c8 with merge ddf63cb...

bors added a commit that referenced this pull request Oct 4, 2019
Revert "Remove tests that only ICE on CI"

This reverts commit 4318854.

If the integration tests pass, this closes #4607
@phansch
Copy link
Member Author

phansch commented Oct 4, 2019

Oh wait, I misread the issue. The test failed on rustc CI, so this will probably work here and potentiallly fail when we update the submodule.

@phansch
Copy link
Member Author

phansch commented Oct 4, 2019

Instead of doing this now, I think it makes more sense to wait for rust-lang/rust#65000 to go through, this way we don't cause needless CI failures when updating the clippy submodule.

@phansch phansch closed this Oct 4, 2019
@phansch phansch deleted the restore_test branch October 4, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty_array.rs test removed because it ICEs on CI
2 participants