Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestion for zero-ptr lint #4599

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Add suggestion for zero-ptr lint #4599

merged 1 commit into from
Oct 2, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Sep 29, 2019 •
edited
Loading

changelog: Improve suggestion of zero_ptr lint

@tesuji tesuji force-pushed the zero-ptr-suggestion branch from d5d52cf to b37f971 Compare September 29, 2019 16:49
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 29, 2019
flip1995
flip1995 reviewed Oct 2, 2019
View reviewed changes
clippy_lints/src/misc.rs Outdated Show resolved Hide resolved
clippy_lints/src/misc.rs Outdated Show resolved Hide resolved
@tesuji tesuji force-pushed the zero-ptr-suggestion branch 3 times, most recently from 3ddd825 to e903b8f Compare October 2, 2019 14:24
flip1995
flip1995 reviewed Oct 2, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good already, I think this should be good with only one change!

clippy_lints/src/misc.rs Outdated Show resolved Hide resolved
clippy_lints/src/misc.rs Outdated Show resolved Hide resolved
clippy_lints/src/misc.rs Outdated Show resolved Hide resolved
@tesuji tesuji force-pushed the zero-ptr-suggestion branch from a1c24bf to b325973 Compare October 2, 2019 14:58
@tesuji tesuji force-pushed the zero-ptr-suggestion branch from 883c3a0 to 6b1a868 Compare October 2, 2019 15:38
flip1995
flip1995 approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Waiting for travis.

@flip1995
Copy link
Member

flip1995 commented Oct 2, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2019

📌 Commit 6b1a868 has been approved by flip1995

bors added a commit that referenced this pull request Oct 2, 2019
@bors
Auto merge of #4599 - lzutao:zero-ptr-suggestion, r=flip1995
737f0a6 
Add suggestion for zero-ptr lint

changelog: Improve suggestion of `zero_ptr` lint
@bors
Copy link
Contributor

bors commented Oct 2, 2019

⌛ Testing commit 6b1a868 with merge 737f0a6...

@bors
Copy link
Contributor

bors commented Oct 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 737f0a6 to master...

@bors bors merged commit 6b1a868 into rust-lang:master Oct 2, 2019
@tesuji tesuji deleted the zero-ptr-suggestion branch October 2, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tesuji @flip1995 @bors @JohnTitor