clippy::cargo_common_metadata: check for license-file #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imp
force-pushed
the
4517_license-file
branch
from
abc0b87 to
1d2524a
Compare
imp
changed the title
imp
force-pushed
the
4517_license-file
branch
2 times, most recently
from
0b389d1 to
ccef83c
Compare
JohnTitor
added
the
S-waiting-on-review
imp
force-pushed
the
4517_license-file
branch
from
ccef83c to
373d6b0
Compare
|
Looks like build fails victim to rust-lang/rust#64231 |
imp
force-pushed
the
4517_license-file
branch
from
373d6b0 to
137a762
Compare
imp
force-pushed
the
4517_license-file
branch
2 times, most recently
from
eb6200c to
bcf9e12
Compare
When license property is missing in Cargo.toml check for license-file as it may be used instead of the former. The check implemented here is very naive as it only verifies that the field is present and is not empty. More scrutiny can be applied by verifying the file is actually present. Fixes rust-lang#4517
imp
force-pushed
the
4517_license-file
branch
from
bcf9e12 to
4c881d1
Compare
|
@bors r+ thanks! |
|
📌 Commit 4c881d1 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 22, 2019
clippy::cargo_common_metadata: check for license-file When license property is missing in Cargo.toml check for license-file as it may be used instead of the former. The check implemented here is very naive as it only verifies that the field is present and is not empty. More scrutiny can be applied by verifying the file is actually present. Fixes #4517 changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
changelog: clippy::cargo_common_metadata now checks for license-file when license is missing