Fix map_entry false positive
#4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
phansch
suggested changes
Sep 4, 2019
| n.insert(k, v); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you also add the following test as described in the issue (where one is mut and the other is not):
fn insert_other<K: Eq + Hash, V>(m: HashMap<K, V>, n: &mut HashMap<K, V>, k: K, v: V) {
if !m.contains_key(&k) {
n.insert(k, v);
}
}There was a problem hiding this comment.
added the test (and renamed)
| @@ -140,6 +140,7 @@ impl<'a, 'tcx, 'b> Visitor<'tcx> for InsertVisitor<'a, 'tcx, 'b> { | |||
| if path.ident.name == sym!(insert); | |||
| if get_item_name(self.cx, self.map) == get_item_name(self.cx, ¶ms[0]); | |||
| if SpanlessEq::new(self.cx).eq_expr(self.key, ¶ms[1]); | |||
| if snippet_opt(self.cx, self.map.span) == snippet_opt(self.cx, params[0].span); | |||
There was a problem hiding this comment.
Hmm, in general I don't think comparing the span's text is very robust, but I think in this case it should be fine 👍
|
r=me with the test added :) |
|
@bors r+ thanks! |
|
📌 Commit 5c760f0 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 4, 2019
Fix `map_entry` false positive Fixes #4219 changelog: Fix `map_entry` false positive
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4219
changelog: Fix
map_entryfalse positive