Fix unused_unit false positive #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
force-pushed
the
fix_unused_unit_sugg
branch
from
f36f520 to
65c8526
Compare
phansch
force-pushed
the
fix_unused_unit_sugg
branch
from
65c8526 to
957dedb
Compare
phansch
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 957dedb has been approved by |
bors
added a commit
that referenced
this pull request
Aug 26, 2019
Fix unused_unit false positive changelog: Fix `unused_unit` false positive For some reason the `expr` of `stmt.node` didn't contain the expansion information, but the `stmt.span` does. Fixes #4076
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix
unused_unitfalse positiveFor some reason the
exprofstmt.nodedidn't contain the expansion information, but thestmt.spandoes.Fixes #4076