Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a structured suggestion for char-lit-as-u8 #4418

Merged
merged 2 commits into from
Sep 4, 2019
Merged

use a structured suggestion for char-lit-as-u8 #4418

merged 2 commits into from
Sep 4, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Aug 20, 2019

changelog: use a structured suggestion for char-lit-as-u8

@euclio euclio force-pushed the byte-lit-suggestion branch from 4405189 to 741d6ee Compare August 20, 2019 02:31
phansch
phansch approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tests would be nice, otherwise LGTM

tests/ui/char_lit_as_u8.rs Show resolved Hide resolved
@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 20, 2019
@euclio euclio force-pushed the byte-lit-suggestion branch from 741d6ee to 379616b Compare August 30, 2019 21:15
@euclio
Copy link
Contributor Author

euclio commented Aug 30, 2019

Just pushed some more tests. I also tweaked the wording a bit more.

flip1995
flip1995 approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a NIT left.

clippy_lints/src/types.rs Outdated Show resolved Hide resolved
@euclio euclio force-pushed the byte-lit-suggestion branch from 379616b to 4ea246b Compare September 4, 2019 12:58
@flip1995
Copy link
Member

flip1995 commented Sep 4, 2019

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2019

📌 Commit 14d1d04 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Sep 4, 2019

⌛ Testing commit 14d1d04 with merge 9d27722...

bors added a commit that referenced this pull request Sep 4, 2019
@bors
Auto merge of #4418 - euclio:byte-lit-suggestion, r=flip1995
9d27722 
use a structured suggestion for char-lit-as-u8

changelog: use a structured suggestion for char-lit-as-u8
@bors
Copy link
Contributor

bors commented Sep 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 9d27722 to master...

@bors bors merged commit 14d1d04 into rust-lang:master Sep 4, 2019
@euclio euclio deleted the byte-lit-suggestion branch September 4, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@euclio @flip1995 @bors @phansch