-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint_single_char_pattern on raw string literal #4361
Fix lint_single_char_pattern on raw string literal #4361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with the tests added and changelog
updated
--> $DIR/single_char_pattern.rs:61:13 | ||
| | ||
LL | x.split(r###"'"###); | ||
| ^^^^^^^^^^ help: try using a char instead: `'/''` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the suggestion is not `'\''`
. It seems really awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that might be caused by some compiletest-rs
normalization of the output. The same happens with other suggestions
@bors r+ thanks! |
📌 Commit b825cdd has been approved by |
…=phansch Fix lint_single_char_pattern on raw string literal Closes #4356 changelog: Handle raw string literal on `single_char_literal` lint.
☀️ Test successful - checks-travis, status-appveyor |
Closes #4356
changelog: Handle raw string literal on
single_char_literal
lint.