don't strip blank lines in lint documentation #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
Sorry for the long wait time! We need to test these doc gen changes by hand, since it is not tested in the CI. This takes some time and motivation 😉 . Just tested this change locally and the documentation looks way cleaner with that change. Thanks! @bors r+ |
|
📌 Commit 4ce100b has been approved by |
bors
added a commit
that referenced
this pull request
Jul 10, 2019
don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes #4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
💔 Test failed - status-appveyor |
|
failure caused by rust-lang/rust#62393 (comment) |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jul 11, 2019
don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes #4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
💔 Test failed - status-appveyor |
flip1995
approved these changes
Jul 11, 2019
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jul 12, 2019
…ip1995 don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes rust-lang#4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jul 12, 2019
don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes #4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
💔 Test failed - checks-travis |
bors
added a commit
that referenced
this pull request
Jul 12, 2019
don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes #4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
💔 Test failed - checks-travis |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 4ce100b has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2019
don't strip blank lines in lint documentation changelog: don't strip blank lines in lint documentation Fixes #4116. This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: don't strip blank lines in lint documentation
Fixes #4116.
This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.