Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move two cast_lossless tests to their correct files #3985

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 17, 2019

First part of checking off the tests/ui/cast.rs checkbox in #3630.

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 17, 2019

Just needs rustfmt

+++set +ex
Diff in /Users/travis/build/rust-lang/rust-clippy/tests/ui/cast.rs at line 2:
     clippy::cast_precision_loss,
     clippy::cast_possible_truncation,
     clippy::cast_sign_loss,
-    clippy::cast_possible_wrap,
+    clippy::cast_possible_wrap
 )]
 #[allow(clippy::no_effect, clippy::unnecessary_operation)]
 fn main() {
tests/ui/cast.rs needs reformatting!
+++'[' true == true ']'
+++echo 'Tests need reformatting!'
Tests need reformatting!

First part of checking off the `tests/ui/cast.rs` checkbox in rust-lang#3630.
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit 8163a1a has been approved by flip1995

bors added a commit that referenced this pull request Apr 18, 2019
Move two cast_lossless tests to their correct files

First part of checking off the `tests/ui/cast.rs` checkbox in #3630.
@bors
Copy link
Collaborator

bors commented Apr 18, 2019

⌛ Testing commit 8163a1a with merge 9130c76...

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

💔 Test failed - status-appveyor

@flip1995
Copy link
Member

Is AppVeyor in shreds again?

@bors retry

@phansch
Copy link
Member Author

phansch commented Apr 18, 2019

Looks like some networking issues:

error: failed to download from `https://crates.io/api/v1/crates/cargo_metadata/0.7.4/download`
Caused by:
  [6] Couldn't resolve host name (Could not resolve host: static.crates.io)

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

⌛ Testing commit 8163a1a with merge 6feed27...

bors added a commit that referenced this pull request Apr 18, 2019
Move two cast_lossless tests to their correct files

First part of checking off the `tests/ui/cast.rs` checkbox in #3630.
@bors
Copy link
Collaborator

bors commented Apr 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 6feed27 to master...

@bors bors merged commit 8163a1a into rust-lang:master Apr 18, 2019
@phansch phansch deleted the move_some_cast_tests branch April 18, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants