Create PULL_REQUEST_TEMPLATE #3972
Conversation
|
While we're at it, we could maybe also add the PR-checklist from the new-lint-documentation to the PR template with the note, that WIP PRs can be opened anytime. |
Users will only see that note if they are already opening a PR... not sure if the note would be helpful at that point. |
I see it as a reminder before pressing the "Open PR" button. Especially the |
|
|
||
| Delete this line and everything above before opening your PR --> | ||
|
|
||
| changelog: none |
There was a problem hiding this comment.
Can this be in the actual PR body? Seems useful for it to be visible
There was a problem hiding this comment.
It is (outside the html-comment-block). Or am I misunderstanding what you're asking?
|
Never mind, reviewing on a phone is hard lol
…On Tue, Apr 16, 2019, 6:27 AM Oliver Scherer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/PULL_REQUEST_TEMPLATE
<#3972 (comment)>
:
> +If you added a new lint, here's a checklist for things that will be
+checked during review or continuous integration.
+
+- [ ] Followed [lint naming conventions][lint_naming]
+- [ ] Added passing UI tests (including committed `.stderr` file)
+- [ ] `cargo test` passes locally
+- [ ] Executed `util/dev update_lints`
+- [ ] Added lint documentation
+- [ ] Run `cargo fmt`
+
+Note that you can skip the above if you are just opening a WIP PR in
+order to get feedback.
+
+Delete this line and everything above before opening your PR -->
+
+changelog: none
It is (outside the html-comment-block). Or am I misunderstanding what
you're asking?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3972 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABivSCMfz6cLd-uy797xnCDhaEYAqB2Rks5vhc_XgaJpZM4cxug5>
.
|
|
@bors r=flip1995,Manishearth |
|
📌 Commit 3b0185b has been approved by |
Create PULL_REQUEST_TEMPLATE changelog: none addresses #3955 (comment)
|
💥 Test timed out |
|
@bors retry |
Create PULL_REQUEST_TEMPLATE changelog: none addresses #3955 (comment)
|
💥 Test timed out |
|
@bors retry (looks like appveyor problems this time) |
Create PULL_REQUEST_TEMPLATE changelog: none addresses #3955 (comment)
|
💥 Test timed out |
|
@bors retry |
Create PULL_REQUEST_TEMPLATE changelog: none addresses #3955 (comment)
|
💥 Test timed out |
|
@bors retry |
Create PULL_REQUEST_TEMPLATE changelog: none addresses #3955 (comment)
|
☀️ Test successful - checks-travis, status-appveyor |
changelog: none
addresses #3955 (comment)