Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta changelog #3956

Merged
merged 3 commits into from
Apr 14, 2019
Merged

Beta changelog #3956

merged 3 commits into from
Apr 14, 2019

Conversation

Manishearth
Copy link
Member

Maintain a changelog for beta so the release team can easily include important additions in the release blog posts.

r? @phansch, @oli-obk

Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the two comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
* Fix suggestion for [`explicit_counter_loop`] to deal with parenthesizing range variables
* Fix suggestion for [`single_char_pattern`] to correctly escape single quotes
* Avoid triggering [`redundant_closure`] in macros
* ICE fixes: #3805, #3772, #3741
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably link to the PR as just the text doesn't seem very useful for readers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought github would autolink

phansch and others added 2 commits April 14, 2019 08:14
@Manishearth
Copy link
Member Author

@bors r=phansch

@bors
Copy link
Collaborator

bors commented Apr 14, 2019

📌 Commit 737e45a has been approved by phansch

@bors
Copy link
Collaborator

bors commented Apr 14, 2019

⌛ Testing commit 737e45a with merge 422ae77...

bors added a commit that referenced this pull request Apr 14, 2019
Beta changelog

Maintain a changelog for beta so the release team can easily include important additions in the release blog posts.

r? @phansch, @oli-obk
@bors
Copy link
Collaborator

bors commented Apr 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 422ae77 to master...

@bors bors merged commit 737e45a into master Apr 14, 2019
@flip1995 flip1995 deleted the beta-clog branch October 28, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants