Add Marwes/combine to integration tests #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repo link: https://github.com/Marwes/combine `combine` uses a lot of macros internally, has been downloaded more than 200_000 times and is also a dependency of [`redis-rs`](https://crates.io/crates/redis). Clippy also previously ICEd on combine in rust-lang#3747 so I think it would be good to have this crate as an integration test.
|
@bors try |
bors
added a commit
that referenced
this pull request
Apr 13, 2019
Add Marwes/combine to integration tests repo link: https://github.com/Marwes/combine `combine` uses a lot of macros internally, has been downloaded more than 200_000 times and is also a dependency of [`redis-rs`](https://crates.io/crates/redis). Clippy also previously ICEd on combine in #3747 so I think it would be good to have this crate as an integration test.
|
☀️ Try build successful - checks-travis, status-appveyor |
|
@bors r+ |
|
📌 Commit 4e72d1e has been approved by |
bors
added a commit
that referenced
this pull request
Apr 14, 2019
Add Marwes/combine to integration tests repo link: https://github.com/Marwes/combine `combine` uses a lot of macros internally, has been downloaded more than 200_000 times and is also a dependency of [`redis-rs`](https://crates.io/crates/redis). Clippy also previously ICEd on combine in #3747 so I think it would be good to have this crate as an integration test.
bors
added a commit
that referenced
this pull request
Apr 14, 2019
Add Marwes/combine to integration tests repo link: https://github.com/Marwes/combine `combine` uses a lot of macros internally, has been downloaded more than 200_000 times and is also a dependency of [`redis-rs`](https://crates.io/crates/redis). Clippy also previously ICEd on combine in #3747 so I think it would be good to have this crate as an integration test.
|
💔 Test failed - checks-travis |
|
@bors r+ |
|
📌 Commit 4e72d1e has been approved by |
bors
added a commit
that referenced
this pull request
Apr 14, 2019
Add Marwes/combine to integration tests repo link: https://github.com/Marwes/combine `combine` uses a lot of macros internally, has been downloaded more than 200_000 times and is also a dependency of [`redis-rs`](https://crates.io/crates/redis). Clippy also previously ICEd on combine in #3747 so I think it would be good to have this crate as an integration test.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repo link: https://github.com/Marwes/combine
combineuses a lot of macros internally, has been downloaded more than 200_000times and is also a dependency of
redis-rs.Clippy also previously ICEd on combine in #3747 so I think it would be
good to have this crate as an integration test.