Fix explicit_counter_loop suggestion

[rail-rain]

#1670

This code seems to me to work, but I have two question.

• Because range expression desugared in hir, Sugg::hir doesn't add parenthesis to range expression. Which function is better to check range do you think, check_for_loop_explicit_counter or hir_from_snippet?
• Do you think we need to distinguish between range expression and struct expression that creates std::ops::Range*?

[flip1995]

Thanks for the contribution and welcome to Clippy!

This LGTM. For suggestions we use the function:

rust-clippy/clippy_lints/src/utils/diagnostics.rs

Lines 169 to 177 in 61aa5c9

	pub fn span_lint_and_sugg<'a, 'tcx: 'a, T: LintContext<'tcx>>(
	cx: &'a T,
	lint: &'static Lint,
	sp: Span,
	msg: &str,
	help: &str,
	sugg: String,
	applicability: Applicability,
	) {

You have to split up the error message into the message and the suggestion.

PS: The currently failing CI is unrelated: #3897

[flip1995]

LGTM now.

Since the CI/Clippy master is currently broken, could you check if you have to run rustfmt?

Otherwise, just the additional test case should be added and this can be merged.

[rail-rain]

I runned rustfmt before committing and I checked this by rustfmt 1.1.0-nightly (1427e4c2 2019-03-17), but how do I assure you it?

[flip1995]

All good, just wanted to remind you, so that I can just merge this and don't have to bother you, once Clippy builds again.

[phansch]

@bors r=flip1995

[bors]

📌 Commit 2b82c71 has been approved by flip1995

[bors]

⌛ Testing commit 2b82c71 with merge 42e1cf3...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 42e1cf3 to master...