-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move lint documentation into macro invocations #3845
Conversation
Thanks for the PR! I must admit that I've never really written a lot of macros. Is there any way to keep the documentation before the macro calls and pass the doc attribute through to Apart from that question, this makes me really happy because it means that the lint documentation is now doc-tested 🎊 |
There isn't a way to keep the documentation before the macro calls, since it gets removed when the macro gets expanded. However, I've actually updated the python script already -- though it probably got lost in this massive diff 😅 I'll push a commit later today to fix the failing doc tests. |
Ok, should be good to go. I ignored most of the doc tests, but I fixed a few that were trivial to fix. |
LGTM, thanks again! @bors r+ |
📌 Commit a9de64a has been approved by |
move lint documentation into macro invocations This PR moves lint documentation inside `declare_clippy_lint!` macro invocations, to avoid triggering the `unused_doc_comments` lint once it's modified in rust-lang/rust#57882. This PR is necessary to unblock that work, since the large number of warnings generated in `clippy_lints` causes Travis to hit the log length limit. This PR also updates the documentation and website generation script. It would be nice to get a clippy update in the Rust repo once this is merged. cc @phansch
☀️ Test successful - checks-travis, status-appveyor |
This PR moves lint documentation inside
declare_clippy_lint!
macro invocations, to avoid triggering theunused_doc_comments
lint once it's modified in rust-lang/rust#57882. This PR is necessary to unblock that work, since the large number of warnings generated inclippy_lints
causes Travis to hit the log length limit.This PR also updates the documentation and website generation script.
It would be nice to get a clippy update in the Rust repo once this is merged.
cc @phansch