Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breakage from rust-lang/rust#57088 #3581

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Dec 25, 2018

No description provided.

36 | | FoodGood,
37 | | FoodMiddle,
38 | | FoodBad,
39 | | }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, why doesn't clippy use -Z ui-testing?
In the compiler it's used quite successfully to avoid this kind of churn in UI test outputs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew this flag existed. But yes, Clippy should use this flag.

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 26, 2018
@flip1995
Copy link
Member

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Dec 26, 2018

📌 Commit cd602c8 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Dec 26, 2018

⌛ Testing commit cd602c8 with merge af14342...

bors added a commit that referenced this pull request Dec 26, 2018
@bors
Copy link
Collaborator

bors commented Dec 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: flip1995
Pushing af14342 to master...

@bors bors merged commit cd602c8 into rust-lang:master Dec 26, 2018
@euclio euclio deleted the camel-case branch December 26, 2018 16:06
bors added a commit that referenced this pull request Dec 28, 2018
Use the -Zui-testing flag for compile-test tests

Like `@petrochenkov` suggested in #3581 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants