Fix clone_on_copy not detecting derefs sometimes
#3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I agree with your analysis. There must be one, otherwise clone could not have been called. Can you add more complex tests with multiple levels of derefs? |
Contributor
Author
|
Oh, I hadn't thought about multiple levels of derefs. Currently this lint will definitely suggest the wrong thing in that case 😅. I'll fix that in a bit. |
Contributor
|
Thanks! (and sorry for letting this sit so long) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could possibly assert that the necessary
Derefimpl actually exists before emitting the lint, but that seems unnecessary to me.Fixes #3052