Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utils::opt_def_id() instead of def_id() to prevent ICE #2867

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Use utils::opt_def_id() instead of def_id() to prevent ICE #2867

merged 1 commit into from
Jun 25, 2018

Conversation

flip1995
Copy link
Member

Fixes #2865

Thanks @mati865 for the quick investigation and the provided example!

@flip1995
Copy link
Member Author

Failures on travis and appveyor are caused by this rust-lang/rust#51699

mati865
mati865 approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@mati865 mati865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustup should be working tomorrow unless something else breaks.
r=me when it's green

@flip1995
Copy link
Member Author

retriggering travis

@flip1995 flip1995 closed this Jun 23, 2018
@flip1995 flip1995 reopened this Jun 23, 2018
@mati865
Copy link
Contributor

mati865 commented Jun 23, 2018

Somebody has to fix #2869 first

@flip1995 flip1995 merged commit 3626d86 into rust-lang:master Jun 25, 2018
@flip1995 flip1995 deleted the ice-2865 branch June 25, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mati865 mati865 mati865 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flip1995 @mati865