disable missing_transmute_annotations lint in local macros - #17683
Open
GTimothy wants to merge 1 commit into
Open
disable missing_transmute_annotations lint in local macros#17683GTimothy wants to merge 1 commit into
GTimothy wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
rustbot
added
the
S-waiting-on-review
CommanderStorm
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the name says, this disables the
missing_transmute_annotationslint in local macros.As discussed in rust-lang/rust#161677 and #17612,
this lint firing in local macros may be a generally bad idea: the point of the lint is that in order to ensure that the safety invariant holds, the transmute source and destination should be explicitly fixed.
In macros, the source or destination may very well be dynamic and dependent on the macro call, which means we cannot always promise safety.
Also, the lint may fire many times with different suggestions, one for each macro call which is very noisy.
Because this is an alternative solution to it, this closes #17612
My thanks to @CommanderStorm
changelog: [
missing_transmute_annotations]: disable the lint in local macros