Skip to content

Do not trigger clippy::exit when expression comes from an external macro - #17105

Merged
llogiq merged 1 commit into
rust-lang:masterfrom
samueltardieu:issues/17082
Jul 24, 2026
Merged

Do not trigger clippy::exit when expression comes from an external macro#17105
llogiq merged 1 commit into
rust-lang:masterfrom
samueltardieu:issues/17082

Conversation

@samueltardieu

@samueltardieu samueltardieu commented May 28, 2026

Copy link
Copy Markdown
Member

changelog: [exit]: do not trigger when the call to exit() comes from an external macro

Fixes #17082

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 28, 2026
@rustbot

rustbot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 8 candidates
  • 8 candidates expanded to 8 candidates
  • Random selection from Jarcho, ada4a, dswij, llogiq

@rustbot

rustbot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@llogiq llogiq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

View changes since this review

@llogiq
llogiq added this pull request to the merge queue Jul 24, 2026
Merged via the queue into rust-lang:master with commit 02dc855 Jul 24, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 24, 2026
@samueltardieu
samueltardieu deleted the issues/17082 branch July 24, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clippy::exit should ignore foreign-macro expansions

4 participants