fix unfulfilled_lint_expectations incorrectly triggered by #[expect(clippy::let_and_return)] - #17045
Open
Gri-ffin wants to merge 1 commit into
Open
fix unfulfilled_lint_expectations incorrectly triggered by #[expect(clippy::let_and_return)]#17045Gri-ffin wants to merge 1 commit into
unfulfilled_lint_expectations incorrectly triggered by #[expect(clippy::let_and_return)]#17045Gri-ffin wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Gri-ffin
commented
May 21, 2026
| let retexpr_attrs = cx.tcx.hir_attrs(retexpr.hir_id); | ||
| retexpr_attrs | ||
| .iter() | ||
| .any(|a| a.name().is_some_and(|name| Level::from_symbol(name, || Some(a.id())).is_some())) |
Contributor
Author
There was a problem hiding this comment.
realistically expect is the only case that makes sense here, but I handled all other lint levels for thoroughness sake.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #17369) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16451
when return expression has lint level attributes, skip the non whitespace check and let the lint fire normally so
#[expect]can fulfil it.changelog: [
let_and_return]: fix#[expect]on return expression causing spuriousunfulfilled_lint_expectations