Implement needless_partial_cmp

[jcarey9149]

View all comments

This lint triggers on cases where PartialOrd::partial_cmp() is called when Ord::cmp() also exists. This removes an unnecessary panic path while being more concise, and future-proofs the comparison if the Ord trait is ever removed from the object, possibly hiding a hard-to-find bug.

changelog: [needless_partial_cmp]: Implement issue 15891

[rustbot]

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq

[github-actions]

Lintcheck changes for 3600599

Lint	Added	Removed	Changed
clippy::needless_partial_cmp	48	0	0

This comment will be updated if you push new changes

[jcarey9149]

Ping?

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

☔ The latest upstream changes (possibly #17329) made this pull request unmergeable. Please resolve the merge conflicts.