fix: add check for image with embedded link by Francisco-Andre-Martins · Pull Request #16773 · rust-lang/rust-clippy

Francisco-Andre-Martins · 2026-03-28T10:10:29Z

This fix adds an aditional check, by checking if the previous element was an image, and ignoring the lack of punctuation for a subsequent link. An aditional test was added to account for this case.

Closes #16439

changelog: [doc_paragraphs_missing_punctuation]: fixed false positive on images with embedded link and added a test for such a case

This fix adds an aditional check, by checking if the previous element was an image, and ignoring the lack of punctuation for a subsequent link. An aditional test was added to account for this case. Closes rust-lang#16439

rustbot · 2026-03-28T10:10:32Z

Some changes occurred in clippy_lints/src/doc

cc @notriddle

rustbot · 2026-03-28T10:10:34Z

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: 7 candidates
7 candidates expanded to 7 candidates
Random selection from Jarcho, dswij, llogiq, samueltardieu

rustbot · 2026-03-28T10:10:35Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 71e4ac9

github-actions · 2026-03-28T10:20:01Z

Lintcheck changes for 71e4ac9

Lint	Added	Removed	Changed
`clippy::doc_paragraphs_missing_punctuation`	0	16	9

This comment will be updated if you push new changes

BenjaminBrienen · 2026-03-30T08:36:18Z

                current_paragraph = None;
            },
-            Event::InlineHtml(_) | Event::Start(Tag::Image { .. }) | Event::End(TagEnd::Image) => {
+            Event::InlineHtml(_) | Event::Start(Tag::Image { .. }) => {


It should be any kind of hyperlink, not just an image.

/// See: <https://example.com>

However you have the following example:
I like potatoes
Which I think should have a comma at the end.

I like potatoes [potatoes](https://en.wikipedia.org/wiki/Potato)

@BenjaminBrienen sorry to bother, just to check if this didn't get lost in your inbox

I agree. Maybe we could base it on whether the URL is bare or not? Or maybe use the : as punctuation if there is only a url after? I would rather not have false positives.

another example that should not trigger the lint:

See: [GitHub: rust-lang/rust-clippy](<https://github.com/rust-lang/rust-clippy>)

of course my remark is not blocking and this is objectively already an improvement, so maybe my comment could be a follow up

@BenjaminBrienen perhaps using https://docs.rs/pulldown-cmark/latest/pulldown_cmark/enum.LinkType.html#variant.Autolink we can better distinguish link types

Still taking a look on this, if relevant still

@BenjaminBrienen I looked into the code, and there is already a test that explicitly considers that autolinks should receive coverage. (I found out when I finally managed to get a fix for it, and found out I was failing tests, lol) . And I am not sure I do want to change the meaning of the lint (unless everyone agrees to it)

enum Exceptions { /// Question marks are fine? QuestionMark, /// Exclamation marks are fine! ExclamationMark, /// Ellipses are ok too… Ellipsis, /// HTML content is however not checked: /// <em>Raw HTML is allowed as well</em> RawHtml, /// The raw HTML exception actually does the right thing to autolinks: /// <https://spec.commonmark.org/0.31.2/#autolinks> //~^ doc_paragraphs_missing_punctuation MarkdownAutolink, /// This table introduction ends with a colon: /// /// | Exception | Note | /// | -------------- | ----- | /// | Markdown table | A-ok | MarkdownTable, }

Francisco-Andre-Martins · 2026-04-09T12:32:23Z

@llogiq sorry to bother, but it seems that this may have gotten lost in your inbox, if you're not the right maintainer, do you mind pointing me in the right direction?

Francisco-Andre-Martins · 2026-04-21T18:12:11Z

@llogiq Has this gotten lost?

Francisco-Andre-Martins · 2026-06-08T13:15:35Z

r? clippy

blyxyas · 2026-06-14T12:22:28Z

Hello @Francisco-Andre-Martins, I hope that you don't mind we using this contribution to teach @medzernik some things about reviewing (they were very interested!).

cc @medzernik Check out this comment first. This one is a little bit different due to this pull request being about documentation. We parse it will pulldown-cmark, so take that into account.

medzernik · 2026-06-14T18:25:49Z

r? @medzernik

Francisco-Andre-Martins · 2026-06-15T11:38:21Z

Hello @Francisco-Andre-Martins, I hope that you don't mind we using this contribution to teach @medzernik some things about reviewing (they were very interested!).

cc @medzernik Check out this comment first. This one is a little bit different due to this pull request being about documentation. We parse it will pulldown-cmark, so take that into account.

No problem, glad to help!

medzernik

Seems to work from my testing... I think I approve? :D

View changes since this review

blyxyas

LGTM, thanks for addressing this issue! ❤️ ฅ•ω•ฅ

Now, let's see how this works.
@rustbot delegate @medzernik

View changes since this review

rustbot · 2026-07-06T20:55:16Z

✌️ @Francisco-Andre-Martins, you can now merge this pull request!

If @blyxyas told you to merge after making some further change, then please make that change and post @rustbot merge.

View changes since this delegation.

blyxyas · 2026-07-06T20:57:05Z

Error in my command! I forgot the =

@rustbot delegate=@medzernik

rustbot · 2026-07-06T20:57:08Z

Error: merge handler unexpectedly failed in this comment: no base sha

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

blyxyas · 2026-07-06T20:58:20Z

Sorry for the ping @Francisco-Andre-Martins, I'll contact the infra team for that last message and see we can fix this issue.

blyxyas · 2026-07-06T21:11:39Z

Anyway, do note that the delegation was registered in the database.

Seems that @medzernik got delegated the PR, even if triagebot didn't respond. So as soon as they take a second (probably the tenth) look, they're allowed to merge!

fix: add check for image with embedded link

71e4ac9

This fix adds an aditional check, by checking if the previous element was an image, and ignoring the lack of punctuation for a subsequent link. An aditional test was added to account for this case. Closes rust-lang#16439

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 28, 2026

rustbot assigned llogiq Mar 28, 2026

notriddle approved these changes Mar 29, 2026

View reviewed changes

BenjaminBrienen reviewed Mar 30, 2026

View reviewed changes

rustbot assigned Jarcho and unassigned llogiq Jun 8, 2026

rustbot assigned medzernik and unassigned Jarcho Jun 14, 2026

medzernik approved these changes Jul 3, 2026

View reviewed changes

blyxyas approved these changes Jul 6, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

Francisco-Andre-Martins commented Mar 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

github-actions Bot commented Mar 28, 2026

Uh oh!

BenjaminBrienen Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminBrienen Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

BenjaminBrienen Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BenjaminBrienen Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Francisco-Andre-Martins commented Apr 9, 2026

Uh oh!

Francisco-Andre-Martins commented Apr 21, 2026

Uh oh!

Francisco-Andre-Martins commented Jun 8, 2026

Uh oh!

blyxyas commented Jun 14, 2026

Uh oh!

medzernik commented Jun 14, 2026

Uh oh!

Francisco-Andre-Martins commented Jun 15, 2026

Uh oh!

medzernik left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blyxyas left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

blyxyas commented Jul 6, 2026

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

blyxyas commented Jul 6, 2026

Uh oh!

blyxyas commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Francisco-Andre-Martins commented Mar 28, 2026 •

edited by rustbot

Loading

Francisco-Andre-Martins Apr 1, 2026 •

edited

Loading

BenjaminBrienen Apr 9, 2026 •

edited

Loading

Francisco-Andre-Martins Apr 21, 2026 •

edited

Loading

medzernik left a comment •

edited by rustbot

Loading

blyxyas left a comment •

edited by rustbot

Loading

blyxyas commented Jul 6, 2026 •

edited

Loading