refactor: arithmetic_side_effects: replace string-based type comparison with DefId/PrimTy lookup - #16730
Open
Tiauma wants to merge 4 commits into
Open
refactor: arithmetic_side_effects: replace string-based type comparison with DefId/PrimTy lookup#16730Tiauma wants to merge 4 commits into
Tiauma wants to merge 4 commits into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
r? samueltardieu |
Member
|
@rustbot reroll |
Contributor
|
Sorry for the delay. I'll review right away. r? @llogiq |
llogiq
reviewed
Jun 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 28, 2026
Member
|
While rebasing the commits, you might also want to squash them. |
Author
|
Ok, thank you. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 2, 2026
Collaborator
|
☔ The latest upstream changes (possibly #17369) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
arithmetic_side_effects]: replace string-based type comparison withDefId/PrimTylookupPreviously, the lint compared types using their string representations,
which was inefficient and failed to recognize type aliases (e.g.,
core→std aliases). This PR:
GeneralTyenum to represent types as eitherPrimTyorDefIdpaths::lookup_path_strand local crate searchFxHashMapin favor ofUnordMap/UnordSetfor deterministic outputFixes rust-lang/rust-clippy#16359