Don't trigger unwrap_used or expect_used on uninhabited Err - #16712
Open
samueltardieu wants to merge 1 commit into
Open
Don't trigger unwrap_used or expect_used on uninhabited Err#16712samueltardieu wants to merge 1 commit into
unwrap_used or expect_used on uninhabited Err#16712samueltardieu wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
samueltardieu
force-pushed
the
features/uninhabited-types-unwrap-expect
branch
from
March 22, 2026 16:27
1399c84 to
f40aac9
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Jarcho
requested changes
Mar 23, 2026
rustbot
added
S-waiting-on-author
When the `Err` variant is a known uninhabited type, there is no point in complaining when `.unwrap()` or `.expect(…)` are used, as they cannot fail. One alternative would be to complain and suggest using `let Ok(_) = _;` which wouldn't fail either, but it may not integrate well into the code flow.
samueltardieu
force-pushed
the
features/uninhabited-types-unwrap-expect
branch
from
June 3, 2026 18:34
f40aac9 to
97b5f4a
Compare
rustbot
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (possibly #17369) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
Errvariant is a known uninhabited type, there is no point in complaining when.unwrap()or.expect(…)are used, as they cannot fail.One alternative would be to complain and suggest using
let Ok(_) = _;which wouldn't fail either, but it may not integrate well into the code flow.changelog: [
unwrap_used] [expect_used]: do not warn onResulttypes whoseErrvariant is visibly uninhabited.