Skip to content

clippy_dev parsing revamp part 6/N - #16644

Merged
llogiq merged 3 commits into
rust-lang:masterfrom
Jarcho:dev_parse6
Jun 28, 2026
Merged

clippy_dev parsing revamp part 6/N#16644
llogiq merged 3 commits into
rust-lang:masterfrom
Jarcho:dev_parse6

Conversation

@Jarcho

@Jarcho Jarcho commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Based on #15979

This part keeps all the parsed source files in memory. These are then borrowed from to avoid allocations and reused when generating which avoids reloading the files. The next PR will also use this when reporting errors.

changelog: none

@Jarcho Jarcho added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Feb 26, 2026
@rustbot

rustbot commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in clippy_lints/src/doc

cc @notriddle

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 26, 2026
@rustbot

rustbot commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from dswij, llogiq, samueltardieu

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@Jarcho Jarcho removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Mar 22, 2026
@rustbot

rustbot commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jarcho

Jarcho commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Ping @llogiq.

@llogiq llogiq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for the delay.

View changes since this review

@llogiq
llogiq added this pull request to the merge queue Jun 28, 2026
Merged via the queue into rust-lang:master with commit 7cb5108 Jun 28, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants