fix(str_to_string): false positive non-str types

[nyurik]

Fix #16569 bug introduced in #16512

changelog: [str_to_string]: fix false positive

r? @samueltardieu

[rustbot]

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[github-actions]

Lintcheck changes for 1994230

Lint	Added	Removed	Changed
clippy::str_to_string	0	8	10

This comment will be updated if you push new changes

[nyurik]

I checked the clippy changes reported in #16571 (comment) - everything seems correct

[Jarcho]

Unrelated, but this can be if let Res::Def(..) = expr.basic_res()

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[nyurik]

@samueltardieu I think this can't be auto-merged until @Jarcho approves it?

[samueltardieu]

Looks like this is blocking the merge. Since you've addressed @Jarcho's point about correctness (peel_refs()), I'll merge this so that it gets included in today's repository sync. If we miss it, we'll have to do a beta backport, and those are usually done at the end of the beta cycle, so we'll have the bug present for 6 more weeks and I think it's a serious issue.

Main point addressed, and need to get included in the repo sync.