Skip to content

Treat f16 and f128 as floats in constant evaluation - #15897

Draft
samueltardieu wants to merge 1 commit into
rust-lang:masterfrom
samueltardieu:features/constant-f16-f128
Draft

Treat f16 and f128 as floats in constant evaluation#15897
samueltardieu wants to merge 1 commit into
rust-lang:masterfrom
samueltardieu:features/constant-f16-f128

Conversation

@samueltardieu

Copy link
Copy Markdown
Member

Basis for enabling handling of f16 and f128 in other existing lints.

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2025
@rustbot

rustbot commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@dswij
dswij added this pull request to the merge queue Oct 17, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@dswij

dswij commented Oct 17, 2025

Copy link
Copy Markdown
Member

@samueltardieu seems like some CI job failed

@samueltardieu

Copy link
Copy Markdown
Member Author

@samueltardieu seems like some CI job failed

Yeah, it looks like MSVC doesn't support some things related to either f16 or f128, I'll investigate.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 17, 2025
@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from d2c4a42 to e03c7af Compare October 27, 2025 06:58
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from e03c7af to 48c7a1d Compare November 5, 2025 12:19
@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from 48c7a1d to 639ed75 Compare November 15, 2025 04:43
@rustbot

rustbot commented Nov 15, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu marked this pull request as draft January 9, 2026 13:16
@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from 639ed75 to b33b060 Compare January 9, 2026 13:17
@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch 2 times, most recently from 98ec9f7 to 3414e2e Compare March 5, 2026 22:19
@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from 3414e2e to 75c2390 Compare March 22, 2026 16:27
@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch 2 times, most recently from 4b0594a to 99fd8a4 Compare June 4, 2026 06:59
@rustbot

This comment has been minimized.

@samueltardieu
samueltardieu force-pushed the features/constant-f16-f128 branch from 99fd8a4 to 0ff760a Compare July 19, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants