Skip to content

rename implicit_saturating_{add,sub} and inverted_saturating_sub - #15707

Closed
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:manual-saturating
Closed

rename implicit_saturating_{add,sub} and inverted_saturating_sub#15707
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:manual-saturating

Conversation

@ada4a

@ada4a ada4a commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

View all comments

As per #clippy > `implicit_saturating_{add,sub}`: rename to `manual_*`

changelog: [implicit_saturating_add]: rename to manual_saturating_add
changelog: [implicit_saturating_sub]: rename to manual_saturating_sub
changelog: [inverted_saturating_sub]: rename to almost_saturating_sub

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2025
@rustbot

rustbot commented Sep 18, 2025

Copy link
Copy Markdown
Collaborator

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions

github-actions Bot commented Sep 18, 2025

Copy link
Copy Markdown

Lintcheck changes for d7d7322

Lint Added Removed Changed
clippy::implicit_saturating_sub 0 3 0
clippy::manual_saturating_sub 3 0 0

This comment will be updated if you push new changes

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from e2fb5e8 to 398e0ec Compare October 4, 2025 19:03
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from 398e0ec to afe18a8 Compare October 7, 2025 14:59
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from afe18a8 to a2661c8 Compare October 23, 2025 17:07
@rustbot rustbot added the needs-fcp PRs that add, remove, or rename lints and need an FCP label Oct 23, 2025
@rustbot

This comment has been minimized.

@ada4a

ada4a commented Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

reviewer is on vacation, let's reroll

r? clippy

@rustbot rustbot assigned samueltardieu and unassigned blyxyas Oct 25, 2025
@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from a2661c8 to b85b08c Compare October 27, 2025 14:18
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from b85b08c to 3742e05 Compare October 31, 2025 20:23
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the manual-saturating branch from 3742e05 to b047768 Compare November 14, 2025 21:55
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@samueltardieu

Copy link
Copy Markdown
Member

Do you still want to do this @ada4a? If you do, can you please open a FCP?

@ada4a
ada4a force-pushed the manual-saturating branch from b047768 to 78569a2 Compare February 21, 2026 17:18
@rustbot

rustbot commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
ada4a force-pushed the manual-saturating branch from 78569a2 to d7d7322 Compare February 21, 2026 17:22
@ada4a

ada4a commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for taking the time to go through the old PRs:)

FCP opened at #clippy > FCP: rename {implicit,inverted}_saturating_{add,sub}

@rustbot

rustbot commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #15979) made this pull request unmergeable. Please resolve the merge conflicts.

@ada4a

ada4a commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Let's do this in one big PR, as per #clippy > FCP: rename {implicit,inverted}saturating{add,sub} @ 💬

@ada4a ada4a closed this Jun 6, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 6, 2026
@ada4a
ada4a deleted the manual-saturating branch June 6, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp PRs that add, remove, or rename lints and need an FCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants