feat: manual_rotate also recognize non-consts - #15402
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Member
Contributor
Author
|
The issue refers to this as a false negative, but I agree that it could be seen as a feature addition. I'm okay with waiting for a bit:) |
rustbot
added
S-blocked
samueltardieu
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
switch around `*_amount` and `*_expr` -- otherwise the order gets confusing now because of both of them being `Expr`s
this is kind of a side-effect of the next commit
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot note remove Feature-freeze |
Contributor
|
Looks good to me. Sorry for the delay. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
manual_rotate]: also recognize non-constsfixes #13028
r? @llogiq