fix: let_with_type_underscore don't eat closing paren in let (i): _ = 0;
#15386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
samueltardieu
approved these changes
Aug 2, 2025
Member
samueltardieu
left a comment
samueltardieu
left a comment
There was a problem hiding this comment.
LGTM. Could you squash the commits?
add failing tests fix also remove whitespace before `:`
ada4a
force-pushed
the
let-with-type-underscore
branch
from
2c938a3 to
0f98da7
Compare
Contributor
Author
|
thank you! done |
rustbot
removed
the
S-waiting-on-review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2025
This kind of supersedes #15386 -- by making the lint early-pass, we get access to `TyKind::Paren`s that surround the type ascription. And with that, we can return to the simpler calculation of `span_to_remove`. The biggest hurdle was `is_from_proc_macro` -- calling that function required me to `impl WithSearchPat for rustc_ast::Ty`, i.e. `ast_ty_search_pat`, which I based on `ty_search_pat`. Since that's a larger change, I could extract it into a PR of its own. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, one can surround a pattern with an arbitrary number of parens, and the resulting
Patwon't include the span of those parens. And the previous approach extended the to-be-deleted span all the way to the end ofPat's span, so it included the closing paren.I think the new approach is more robust anyway, since all we care to remove (besides the
_) is the:, so we search just for that.This does leave one extra whitespace in one of the test cases, but I'd say let rustfmt handle that.fixed in the third commitchangelog: [
let_with_type_underscore]: don't eat closing paren inlet (i): _ = 0;fixes #15377