Split possible_missing_else from suspicious_else_formatting
#15317
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
|
No changes for 9e50049 |
rustbot
added
S-blocked
samueltardieu
approved these changes
Jul 30, 2025
Member
samueltardieu
left a comment
samueltardieu
left a comment
There was a problem hiding this comment.
I think this should be merged as-is. Even if this creates a new lint, it doesn't add any new functionality, so it is still in the spirit of the feature freeze and cleans things up.
blyxyas
approved these changes
Aug 4, 2025
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
Taking Samuel's approval as the necessary one for the FCP. In the case that this needed an FCP. Also, I think we asked Philipp about this and he didn't have any hard feelings.
blyxyas
removed
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has always been one lint (added in #720), but the two cases are also quite distinct.
changelog: Split
possible_missing_elsefromsuspicious_else_formattingSummary Notes
Managed by
@rustbot—see help for details