Fix let_unit_value suggests wrongly for format macros
#15085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
r? clippy |
Contributor
Author
|
r? clippy |
ada4a
reviewed
Jul 27, 2025
| let res = return_unit(); | ||
| //~^ let_unit_value | ||
| do_something(res); | ||
| println!("{res:?}"); |
Contributor
There was a problem hiding this comment.
Would it be possible to include a (non-machine-applicable) suggestion to remove this res as well? Then we could get rid of let res = entirely
Contributor
There was a problem hiding this comment.
I'm ok with this PR as is. Further improvements can have their own PRs, as a treat.
Contributor
|
Thank you! |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15061
changelog: [
let_unit_value] fix wrong suggestions for format macros