Skip to content

Don't trigger unused_trait_names in macros #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Don't trigger unused_trait_names in macros #14947

merged 2 commits into from
Jul 16, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jun 1, 2025 •
edited by flip1995
Loading

Closes #14924

changelog: [unused_trait_names] no longer triggers in macros

@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2025
samueltardieu
samueltardieu previously requested changes Jun 1, 2025
View reviewed changes
@profetia profetia requested a review from dswij June 18, 2025 12:38
@profetia
Copy link
Contributor Author

profetia commented Jun 30, 2025

r? samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned dswij Jun 30, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Jun 30, 2025

r? clippy

@rustbot rustbot assigned llogiq and unassigned samueltardieu Jun 30, 2025
@profetia
Copy link
Contributor Author

profetia commented Jul 14, 2025

r? clippy

@rustbot rustbot assigned flip1995 and unassigned llogiq Jul 14, 2025
flip1995
flip1995 approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @samueltardieu you still have changes requested, I think this is a stale review. I'll wait a day or two before merging, for you to resolve it. But as it is a stale review, I won't keep this PR blocked on it.

@flip1995 flip1995 changed the title Fix unused_trait_names FP when as name is from macro input Don't trigger unused_trait_names when as name is from macro input Jul 15, 2025
@flip1995 flip1995 changed the title Don't trigger unused_trait_names when as name is from macro input Don't trigger unused_trait_names in macros Jul 15, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Jul 15, 2025

LGTM. @samueltardieu you still have changes requested, I think this is a stale review. I'll wait a day or two before merging, for you to resolve it. But as it is a stale review, I won't keep this PR blocked on it.

Yes, sorry about that, it was stale indeed.

@flip1995 flip1995 added this pull request to the merge queue Jul 16, 2025
Merged via the queue into rust-lang:master with commit 21943a9 Jul 16, 2025
16 of 17 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 16, 2025
@profetia profetia deleted the issue14924 branch September 12, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995 flip1995 flip1995 approved these changes

@samueltardieu samueltardieu samueltardieu left review comments

@dswij dswij Awaiting requested review from dswij

Assignees

@flip1995 flip1995

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FP unused_trait_names

6 participants

@profetia @rustbot @samueltardieu @flip1995 @dswij @llogiq