Skip to content

Conversation

@flip1995
Copy link
Member

r? @ghost

changelog: none

mejrs and others added 16 commits May 17, 2025 15:15
Because the empty string is not a keyword.
rustc_on_unimplemented cleanups

Addresses some of the fixmes from rust-lang/rust#139091 and rust-lang/rust#140307.

- switch from `_Self` to `Self` in library
- properly validate that arguments in the `on` filter and the format strings are actually valid

See rust-lang/rustc-dev-guide#2357 for the relevant documentation.
Rename `kw::Empty` as `sym::empty`.

Because the empty string is not a keyword.

r? `@petrochenkov`
…li-obk

Properly analyze captures from unsafe binders

We need to represent the unsafe binder unwrap as an adjustment in HIR. Pretty straightforward b/c we already represent it as a projection elem in MIR.

Fixes #141418
Fixes #141417

r? oli-obk
So they match the order of the parts in the source code, e.g.:
```
struct Foo<T, U> { t: T, u: U }
       <-><----> <------------>
       /   |       \
   ident generics  variant_data
```
Use `builtin_index` instead of hand-rolling it

Just using the dedicated method more
Reorder `ast::ItemKind::{Struct,Enum,Union}` fields.

So they match the order of the parts in the source code, e.g.:
```
struct Foo<T, U> { t: T, u: U }
       <-><----> <------------>
       /   |       \
   ident generics  variant_data
```

r? `@fee1-dead`
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#138285 (Stabilize `repr128`)
 - rust-lang/rust#139994 (add `CStr::display`)
 - rust-lang/rust#141571 (coretests: extend and simplify float tests)
 - rust-lang/rust#141656 (CI: Add cargo tests to aarch64-apple-darwin)

Failed merges:

 - rust-lang/rust#141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`)
 - rust-lang/rust#141636 (avoid some usages of `&mut P<T>` in AST visitors)

r? `@ghost`
`@rustbot` modify labels: rollup
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2025
@flip1995 flip1995 enabled auto-merge May 31, 2025 12:13
@flip1995 flip1995 added this pull request to the merge queue May 31, 2025
Merged via the queue into rust-lang:master with commit 57cbadd May 31, 2025
11 checks passed
@flip1995 flip1995 deleted the rustup branch May 31, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.