Skip to content

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented May 4, 2025

Closes #14598

Implemented checks for simple enum variants when checking if match arms are disjointed.

changelog: [manual_let_else] fix FN when diverges on simple enum variant

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 4, 2025
@rustbot

This comment has been minimized.

@profetia
Copy link
Contributor Author

profetia commented May 7, 2025

Hmm.. Why isn't this PR merged automatically?

@samueltardieu
Copy link
Member

The PR are never merged automatically in this repository, the assigned reviewer has to press the "Merge when ready" button.

@dswij
Copy link
Member

dswij commented May 7, 2025

Whoops yeah, I might've forgotten to click the merge button. 😅

@dswij dswij added this pull request to the merge queue May 7, 2025
@dswij dswij removed this pull request from the merge queue due to a manual request May 7, 2025
@dswij dswij added this pull request to the merge queue May 7, 2025
Merged via the queue into rust-lang:master with commit f88f9a9 May 7, 2025
11 checks passed
@nyurik
Copy link
Contributor

nyurik commented May 7, 2025

thank you!

@profetia profetia deleted the issue14598 branch September 12, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manual_let_else not suggesting a fix for match statement

6 participants