Make annotations mandatory for internal ui tests #14393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Mar 12, 2025
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
Nice! Was the assert->span_delayed_bug change necessary for this to work?
Comment on lines
12
to
+13
| fn it_looks_like_you_are_trying_to_kill_clippy() {} | ||
| //~^ ice: Would you like some help with that? |
Member
There was a problem hiding this comment.
I love that the error message is now also there. This makes the joke complete 🎉
Member
Author
Yep because otherwise it's not emitted as JSON, preventing |
Member
Author
|
Fixed failing test. :) |
Member
Nice! Happy that my guess was useful 🎉 |
Member
Author
|
It definitely saved me time investigating what was going on. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #11421.
Now all ui tests require annotations.
The change in
ui_testis to addICE:errors.changelog: Make internals ui tests annotations mandatory
r? @flip1995