Use a lintcheck specific Clippy configuration file in the CI #14233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @flip1995 |
|
I wonder if we should enable |
samueltardieu
force-pushed
the
push-pxvyoozrxozs
branch
from
6e26ad1 to
172d709
Compare
Let's try a run with it! |
|
That didn't change anything for the default lintcheck run, we can let it in. |
By default, lintcheck will use the `clippy.toml` file found at the toplevel of the repository (`CARGO_MANIFEST_DIR`). This file is meant for configuration of Clippy applied to Clippy sources. This creates a new `lintcheck/ci-config/clippy.toml` file which is used by the CI when running lintcheck. By default this uses the default Clippy configuration.
samueltardieu
force-pushed
the
push-pxvyoozrxozs
branch
from
172d709 to
e1d6f1f
Compare
|
Rebased |
flip1995
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, lintcheck will use the
clippy.tomlfile found at the toplevel of the repository (CARGO_MANIFEST_DIR). This file is meant for configuration of Clippy applied to Clippy sources.This creates a new
lintcheck/ci-config/clippy.tomlfile which is used by the CI when running lintcheck. By default this uses the default Clippy configuration.changelog: none