Skip to content

chore: use multipart_suggestion in significant_drop_tightening lint #13823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2024
Merged

chore: use multipart_suggestion in significant_drop_tightening lint #13823

merged 1 commit into from
Dec 14, 2024

Conversation

@scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Dec 13, 2024 •
edited by xFrednet
Loading

This addresses #13099 for the significant_drop_tightening lint.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 13, 2024
@scottgerring scottgerring marked this pull request as ready for review December 13, 2024 09:57
@xFrednet
Copy link
Contributor

xFrednet commented Dec 14, 2024

The changes look good to me, thanks!

Roses are red,
violets are blue,
suggestion are tightened,
like the lint

@xFrednet xFrednet added this pull request to the merge queue Dec 14, 2024
Merged via the queue into rust-lang:master with commit 5ac1805 Dec 14, 2024
9 checks passed
@scottgerring scottgerring deleted the chore/fix-significant-drop-tightening branch December 15, 2024 08:54
@scottgerring
Copy link
Contributor Author

scottgerring commented Dec 15, 2024

@xFrednet thanks for the review, and the poetry 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xFrednet xFrednet xFrednet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xFrednet xFrednet

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottgerring @rustbot @xFrednet