Reverse dependency between clippy_utils and clippy_config
#13691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
This PR is best reviewed by just reviewing the first 2 commits. The last commit is just an automated renaming using |
blyxyas
approved these changes
Nov 15, 2024
clippy_config/src/lib.rs
Outdated
Comment on lines
16
to
23
| extern crate rustc_ast; | ||
| extern crate rustc_attr; | ||
| #[allow(unused_extern_crates)] | ||
| extern crate rustc_driver; | ||
| extern crate rustc_errors; | ||
| extern crate rustc_session; | ||
| extern crate rustc_span; | ||
| extern crate smallvec; |
There was a problem hiding this comment.
I really like the removal of these dependencies (although they seemed to not be used, so I'm not sure if they ended up being linked to in the final executable).
I'm currently looking into the possibility of if being tied to rustc_driver*.so could be slowing us down by a considerable factor.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2024
Follow up to #13691 Adds metadata to the `clippy_utils/Cargo.toml`, which is mostly copied from the root `Cargo.toml`. Adds a `README.md` file listing the nightly version `clippy_utils` can be used with, mentions that there are no stability guarantees and the license. The next PR will add automation to update the nightly toolchains in those files and the versions in the `Cargo.toml`s. cc #13556 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of #13556, I want to remove the dependency on
clippy_config, as I don't think that we want to publish that for outside consumers. To do this the 2 dependecies onclippy_confighad to be removed:clippy_config, but was required inqualify_min_const. I think exposing the MSRV infrastructure and the MSRVs we defined might also be helpful forclippy_utilsusers. I don't see why it should not be able to live inclippy_utilsfrom a technical point of few.create_disallowed_mapfunction that took in aclippy_utils::types::DisallowedPathis moved to theDisallowedPathimplementation. This also fits there and is only useful for Clippy and not inclippy_utilsfor external consumers.clippy_confignow depends inclippy_utils, so the dependecy just got reversed. But having theclippy_utilscrate as the base of the dependency tree in Clippy makes sense.changelog: none