Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Option::map_or(true, …) in unnecessary_map_or lint #13653

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Handle Option::map_or(true, …) in unnecessary_map_or lint #13653

merged 3 commits into from
Nov 18, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 4, 2024 •
edited
Loading

changelog: [unnecessary_map_or]: handle Option::map_or(true, …)

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2024
@samueltardieu
Copy link
Contributor Author

Even though it is not to be merged yet (mostly because #11796 isn't merged),

r? @Centri3

@rustbot rustbot assigned Centri3 and unassigned Jarcho Nov 4, 2024
@bors
Copy link
Contributor

bors commented Nov 7, 2024

☔ The latest upstream changes (presumably #13639) made this pull request unmergeable. Please resolve the merge conflicts.

@samueltardieu samueltardieu marked this pull request as ready for review November 7, 2024 19:33
@samueltardieu samueltardieu mentioned this pull request Nov 7, 2024
Merged
@samueltardieu samueltardieu force-pushed the push-oqltkmvvzmlq branch 2 times, most recently from 8957f14 to b90678d Compare November 13, 2024 07:41
@samueltardieu
Copy link
Contributor Author

In addition to the fixed instances in Clippy itself, lintcheck found one instance in Cargo. Since it requires at least a 1.82 Rust version, we will see a progressive effect as the MSRV of the targets advance.

@bors
Copy link
Contributor

bors commented Nov 15, 2024

☔ The latest upstream changes (presumably 627363e) made this pull request unmergeable. Please resolve the merge conflicts.

Centri3
Centri3 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks!

@Centri3 Centri3 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into rust-lang:master with commit d3edd05 Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 approved these changes

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samueltardieu @rustbot @bors @Centri3 @Jarcho