Cleanup const_float_classify
#13510
Open
Cleanup const_float_classify
#13510
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
alex-semenyuk
changed the title
const_float_classifyconst_float_classify
y21
reviewed
Oct 6, 2024
| && ( | ||
| matches!(cx.tcx.constness(cx.tcx.hir().enclosing_body_owner(expr.hir_id)), Constness::NotConst) | ||
| || cx.tcx.features().declared(sym!(const_float_classify)) | ||
| ) | ||
| && matches!(cx.tcx.constness(cx.tcx.hir().enclosing_body_owner(expr.hir_id)), Constness::NotConst) |
There was a problem hiding this comment.
If I understand the issue correctly, it sounds like we should rather replace the cx.tcx.features().declared(...) check with an MSRV check, since these functions are now stable in const.
With the current diff, we would never emit a warning in const code
Comment on lines
-43
to
47
| // Will be linted if `const_float_classify` is enabled | ||
| if const { X == f64::INFINITY || X == f64::NEG_INFINITY } {} |
There was a problem hiding this comment.
Would be good to have a test where this now emits a warning. Something like
const {
let x = 1.0f64;
if x == f64::INFINITY || x == f64::NEG_INFINITY {}
}should suffice I think
alex-semenyuk
force-pushed
the
cleanup_const_float_classify
branch
from
55688a8
to
55d1e88
Compare
alex-semenyuk
force-pushed
the
cleanup_const_float_classify
branch
2 times, most recently
from
55d1e88
to
3f68c41
Compare
alex-semenyuk
force-pushed
the
cleanup_const_float_classify
branch
from
a100fd2
to
cb19f23
Compare
|
Looks good to me. Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Oct 13, 2024
…llogiq Cleanup `const_float_classify` As mentioned at #13508 `const_float_classify` has been stabilized recently in rust-lang/rust#130157 and can be cleanup Close #13508 changelog: [none]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at #13508
const_float_classifyhas been stabilized recently in rust-lang/rust#130157 and can be cleanupClose #13508
changelog: [none]