Fix false positive for needless_character_iteration lint
#12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
fix-needless_character_iteration
branch
from
cc46063 to
312c7f3
Compare
blyxyas
requested changes
Jun 4, 2024
| ExprKind::Call(fn_path, [arg]) => { | ||
| if let ExprKind::Path(path) = fn_path.kind | ||
| && let Some(fn_def_id) = cx.qpath_res(&path, fn_path.hir_id).opt_def_id() | ||
| && match_def_path(cx, fn_def_id, &["core", "char", "methods", "<impl char>", "is_ascii"]) | ||
| && path_to_local_id(peels_expr_ref(arg), first_param) | ||
| && let Some(snippet) = snippet_opt(cx, before_chars) | ||
| // If we have `!is_ascii`, then only `.any()` should warn. And if the condition is | ||
| // `is_ascii`, then only `.all()` should warn. | ||
| && revert != is_all |
There was a problem hiding this comment.
Could you lift this to avoid running the expensive conditions unnecessarily? (Same with the other condition)
GuillaumeGomez
force-pushed
the
fix-needless_character_iteration
branch
from
312c7f3 to
158b658
Compare
|
Moved the condition sooner for better performance as suggested. |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12879.
changelog: Fix false positive for
needless_character_iterationlint