Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more attributes in clippy::useless_attribute #12755

Merged
merged 6 commits into from
May 6, 2024

Conversation

9999years
Copy link
Contributor

Fixes #12753
Fixes #4467
Fixes #11595
Fixes #10878

changelog: [useless_attribute]: Attributes allowed on use items now include ambiguous_glob_exports, hidden_glob_reexports, dead_code, unused_braces, and clippy::disallowed_types.

@rustbot
Copy link
Collaborator

rustbot commented May 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 2, 2024
@9999years
Copy link
Contributor Author

@rustbot review

@xFrednet
Copy link
Member

xFrednet commented May 2, 2024

Thank you for the PR and welcome to Clippy 🎉 I'll take a look at it soon, most likely during the weekend :D

@GuillaumeGomez If you have the time, you could do a prereview :D

@9999years 9999years force-pushed the useless-attribute branch from 577536b to 45305b6 Compare May 2, 2024 21:48
@9999years
Copy link
Contributor Author

@rustbot review

@9999years 9999years requested a review from xFrednet May 2, 2024 21:48
@GuillaumeGomez
Copy link
Member

Sure!

Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my suggestion, looks all good to me, thanks!

@9999years 9999years force-pushed the useless-attribute branch from 45305b6 to 566bfff Compare May 6, 2024 19:27
@9999years
Copy link
Contributor Author

@rustbot review

@xFrednet
Copy link
Member

xFrednet commented May 6, 2024

Looks good to me, thank you for the changes!

@bors r=xFrednet,GuillaumeGomez

@bors
Copy link
Contributor

bors commented May 6, 2024

📌 Commit 566bfff has been approved by xFrednet,GuillaumeGomez

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2024

⌛ Testing commit 566bfff with merge befb659...

@bors
Copy link
Contributor

bors commented May 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet,GuillaumeGomez
Pushing befb659 to master...

@bors bors merged commit befb659 into rust-lang:master May 6, 2024
5 checks passed
@9999years 9999years deleted the useless-attribute branch May 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
5 participants