-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more attributes in clippy::useless_attribute
#12755
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@rustbot review |
Thank you for the PR and welcome to Clippy 🎉 I'll take a look at it soon, most likely during the weekend :D @GuillaumeGomez If you have the time, you could do a prereview :D |
577536b
to
45305b6
Compare
@rustbot review |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my suggestion, looks all good to me, thanks!
45305b6
to
566bfff
Compare
@rustbot review |
Looks good to me, thank you for the changes! @bors r=xFrednet,GuillaumeGomez |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #12753
Fixes #4467
Fixes #11595
Fixes #10878
changelog: [
useless_attribute
]: Attributes allowed onuse
items now includeambiguous_glob_exports
,hidden_glob_reexports
,dead_code
,unused_braces
, andclippy::disallowed_types
.